Fix broken npm install (missing dist) + add CI#2
Merged
Conversation
Published nori-slack-cli@0.1.0 shipped without dist/, so `npm install -g` symlinked bin to a missing file. Add files: ["dist"] and prepare script so the tarball contains the compiled output, bump to 0.1.1, and add an end-to-end packaging test that runs on every npm test. Also add pr-ci and main-ci GitHub workflows pinned to Node 22. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech> 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
nori-slack-cli@0.1.0on npm shipped withoutdist/, sonpm install -g nori-slack-clicreated anori-slackbin pointing at a missing file. Fix: add"files": ["dist"]and"prepare": "npm run build"topackage.json; bump to0.1.1.test/packaging.test.tsblack-box test thatnpm packs (in an isolated tmpdir to avoid racing withbuild.test.ts), installs the tarball into another tmpdir, and runsnori-slack list-methods --namespace chat— verifies the install works end-to-end. Runs on everynpm test..github/workflows/pr-ci.yaml+main-ci.yamlmirroringnori-registrarconventions (kebab-case names, single-entry matrix,.nvmrc-driven Node 22). Steps: install → build → test.README.mdnow documentsnpm install -g nori-slack-clias the primary install path;docs.md/src/docs.md/test/docs.mdcorrected for pre-existing stale claims (e.g., thatpostbuildrunsnpm link, which it never did) and new packaging invariants.Test Plan
npm publish(manual, from a clean checkout),npm install -g nori-slack-cli@0.1.1exposes a workingnori-slackon PATH.nori-slack list-methods --namespace chatreturns JSON withchat.postMessagein the methods array.nori-slack --versionprints0.1.1.Notes / open questions for review
@v3to matchnori-registrar— happy to bump to@v4in a follow-up if preferred.src/index.tshas a hardcoded.version('0.1.1')duplicate withpackage.json. Left as-is —test/build.test.tsalready enforces drift detection by asserting--versionmatchespkg.version.0.1.0from npm. Within the 72h window it is possible vianpm unpublish nori-slack-cli@0.1.0— your call.Share Nori with your team: https://www.npmjs.com/package/nori-skillsets